-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore karma tokens inside code blocks #547
base: master
Are you sure you want to change the base?
Conversation
No funciona si hay un karma fuera de los code blocks igual al que está adentro |
const findTextInsideCodeBlocks = message => { | ||
const regex = /`(.*?)`/g | ||
let matches = [] | ||
let match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cual es el beneficio de este let
?
while ((match = regex.exec(message)) !== null) { | ||
matches.push(match[0]) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no sería mejor usar un mecanismo tipo optional
para esto?
Encuentro que darle con el while es como darse muchas vueltas
fde96ef
to
d12d3d6
Compare
Pequeño cambio para evitar asignar karma cuando se agrega código.
Cualquier cosa que este dentro ` (backtick) va a ser escapada de la asignación de karma.
TLDR; No más
no encuentro al usuario c++